[PATCH] ubi-utils: fix warning in fprintf() code
Mike Frysinger
vapier at gentoo.org
Mon Jan 12 11:08:07 EST 2009
When building with gcc security warnings enabled, the ubimirror.c code
triggers this warning:
./src/ubimirror.c: In function 'main':
./src/ubimirror.c:206: error: format not a string literal and no format arguments
Since the buffer in question should be a straight string anyways, avoid
ugly printf exploits by outputting the string indirectly:
printf("%s", buffer)
Signed-off-by: Mike Frysinger <vapier at gentoo.org>
---
ubi-utils/src/ubimirror.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ubi-utils/src/ubimirror.c b/ubi-utils/src/ubimirror.c
index 2cc4596..a20e1af 100644
--- a/ubi-utils/src/ubimirror.c
+++ b/ubi-utils/src/ubimirror.c
@@ -203,7 +203,7 @@ main(int argc, char **argv) {
err_buf, sizeof(err_buf));
if( rc ){
err_buf[sizeof err_buf - 1] = '\0';
- fprintf(stderr, err_buf);
+ fprintf(stderr, "%s", err_buf);
if( rc < 0 )
rc = -rc;
}
--
1.6.1
More information about the linux-mtd
mailing list