[PATCH] CFI: remove major/minor version check for command set 0x0002

[Nicolas Pitre]

On Thu, 8 Jan 2009, Wolfgang Grandegger wrote:

> David Woodhouse wrote:
> > On Thu, 2009-01-08 at 11:47 -0500, Nicolas Pitre wrote:
> >>> The NOR Flash memory K8P2815UQB from Samsung uses the major version
> >>> number '0', which seems to be unusual but not illegal, IIUC. This
> >>> patch removes the major-minor version check to get this Flash memory
> >>> supported as well.
> >> Instead of removing the test entirely, I'd suggest you augment it with 
> >> the manufacturer ID (cfi->mfr and cfi->id).  Or better yet, just use 
> >> that information to fix up the version number to something sensible.
> > 
> > Couldn't you use a quirk to do the latter?
> 
> The major/minor version number is not used anywhere else and therefore a
> quirk seems to be overkill too me.

Please look again.  Searching for "MinorVersion" turns up a couple 
places.

A quirk is not overkill at all.  To the contrary it's the whole purpose 
of quirks to fix up things like this.

Although, in this case, I think quirks are evaluated only after the CFI 
version is tested, meaning that the fixup might have to be done inline.


Nicolas