[PATCH 2/3] Coding style clean-up

Lothar Waßmann LW at KARO-electronics.de
Wed Jan 7 04:01:01 EST 2009


Hi,

> > -	dev_warn(&info->pdev->dev,
> > -		 "failed to detect configured nand flash; found %04x instead of\n",
> > -		 id);
> > +	dev_warn(&info->pdev->dev, "failed to detect configured nand flash; "
> > +			"found %04x instead of\n", id);
> 
> This is OK.
> 
I personally don't like strings being split up to fit the line length
limitation. It makes it just harder to locate a certain kernel message
in the source code. Anyway the message text seems to be incomplete:
'found %04x instead of' what?


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________



More information about the linux-mtd mailing list