[PATCH 3/3] UBI: is_mapped operation via ioctl

Artem Bityutskiy dedekind at infradead.org
Mon Jan 5 09:33:29 EST 2009


On Mon, 2009-01-05 at 15:07 +0100, Corentin Chary wrote:
> diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h
> index bcff3a0..a65c4ab 100644
> --- a/include/mtd/ubi-user.h
> +++ b/include/mtd/ubi-user.h
> @@ -137,6 +137,8 @@
>  #define UBI_IOMAP   _IOW(UBI_VOL_IOC_MAGIC, 3, struct ubi_map_req)
>  /* Unmap an eraseblock */
>  #define UBI_IOUNMAP _IOW(UBI_VOL_IOC_MAGIC, 4, int32_t)
> +/* check whether an eraseblock is mapped */
Bettert to start from capital "C".

> +#define UBI_IOISMAP _IOW(UBI_VOL_IOC_MAGIC, 5, int32_t)
I think this should be _IOR instead.

_IOR: data is transferred from kernel to user-space
_IOW: data is transferred from user-space to kernel
_IORW: both directions

Otherwise, the patches look OK for me.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list