[PATCH] max_retries reaches -1, not 0

[Sascha Hauer]

On Tue, Feb 10, 2009 at 11:43:00PM +0100, Roel Kluin wrote:
> With while (max_retries-- > 0) { ... } max_retries reaches -1, not 0,
> so we shouldn't DEBUG() on a max_retries of 0.

Yes, indeed.

> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>

Acked-by: Sascha Hauer <s.hauer at pengutronix.de>

> ---
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 21fd4f1..5c34148 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -192,7 +192,7 @@ static void wait_op_done(struct mxc_nand_host *host, int max_retries,
>  			}
>  			udelay(1);
>  		}
> -		if (max_retries <= 0)
> +		if (max_retries < 0)
>  			DEBUG(MTD_DEBUG_LEVEL0, "%s(%d): INT not set\n",
>  			      __func__, param);
>  	}


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |