[patch 2.6.29-rc3] NAND: fix broken debug messages
Josh Boyer
jwboyer at gmail.com
Tue Feb 3 07:35:07 EST 2009
On Mon, Feb 02, 2009 at 06:13:20PM -0800, David Brownell wrote:
>From: David Brownell <dbrownell at users.sourceforge.net>
>
>Fix incorrect debug messages (*write* not read); someone
>committed some cut'n'paste bugs. There might be more,
>I only noticed these since I was looking for nand_read
>usage and landed in some very wrong functions.
>
>Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
>---
> drivers/mtd/nand/nand_base.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>--- a/drivers/mtd/nand/nand_base.c
>+++ b/drivers/mtd/nand/nand_base.c
>@@ -1948,7 +1948,7 @@ static int nand_do_write_oob(struct mtd_
> }
>
> if (unlikely(ops->ooboffs >= len)) {
>- DEBUG(MTD_DEBUG_LEVEL0, "nand_read_oob: "
>+ DEBUG(MTD_DEBUG_LEVEL0, "nand_do_write_oob: "
> "Attempt to start write outside oob\n");
> return -EINVAL;
> }
>@@ -1958,7 +1958,7 @@ static int nand_do_write_oob(struct mtd_
> ops->ooboffs + ops->ooblen >
> ((mtd->size >> chip->page_shift) -
> (to >> chip->page_shift)) * len)) {
>- DEBUG(MTD_DEBUG_LEVEL0, "nand_read_oob: "
>+ DEBUG(MTD_DEBUG_LEVEL0, "do_nand_write_oob: "
This is wrong too. The function is called 'nand_do_write_oob'.
Which leads me to wonder why we aren't doing something like:
DEBUG(MTD_DEBUG_LEVEL0, "%s: <message>\n", __func__);
josh
More information about the linux-mtd
mailing list