[PATCH] UBIFS: fix commentaries
Artem Bityutskiy
dedekind at infradead.org
Tue Aug 25 11:27:04 EDT 2009
From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
Change "write-back does take inode @i_mutex" to "write-back does not
take inode @i_mutex" type. IOW, this patch just adds "not" word, the
rest of the changes are just re-formatting to fit the 80 characters
line limit.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
---
fs/ubifs/file.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 6d34dc7..ff43f60 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -965,12 +965,12 @@ static int do_writepage(struct page *page, int len)
* and then keeps writing pages back.
*
* Some locking issues explanation. 'ubifs_writepage()' first is called with
- * the page locked, and it locks @ui_mutex. However, write-back does take inode
- * @i_mutex, which means other VFS operations may be run on this inode at the
- * same time. And the problematic one is truncation to smaller size, from where
- * we have to call 'vmtruncate()', which first changes @inode->i_size, then
- * drops the truncated pages. And while dropping the pages, it takes the page
- * lock. This means that 'do_truncation()' cannot call 'vmtruncate()' with
+ * the page locked, and it locks @ui_mutex. However, write-back does not take
+ * inode @i_mutex, which means other VFS operations may be run on this inode at
+ * the same time. And the problematic one is truncation to smaller size, from
+ * where we have to call 'vmtruncate()', which first changes @inode->i_size,
+ * then drops the truncated pages. And while dropping the pages, it takes the
+ * page lock. This means that 'do_truncation()' cannot call 'vmtruncate()' with
* @ui_mutex locked, because it would deadlock with 'ubifs_writepage()'. This
* means that @inode->i_size is changed while @ui_mutex is unlocked.
*
--
1.6.2.5
More information about the linux-mtd
mailing list