[Patch 1/1] don't suspend erase for erase in cfi_cmdset_0002

[Peter Wippich]

Hi Jocke,

On Mon, 3 Aug 2009, Joakim Tjernlund wrote:

> Hi again :)
> 
> I think mine is better because:
> 1) It matches cmdset_0001 and the code in general better.
> 2) It can handle FL_WRITING too.
> 
> But I am not the maintainer and I don't use 0002 myself, just trying to
> help out.
> 
> I hope you will constuct a cfip too for your JEDEC chips. It is no
> fun to be without erase suspend :(
> 

It's fine to have some discussion about that. From that at least we agree 
that something is wrong here. The main difference between the suggested 
patches is the change in behaviour from the current implementation. 
Currently the default behaviour is that erase suspend will work with jedec 
and cfi probed chips. I can not tell if this is by intention or by chance, 
but I think if we change something it should not break existing 
implementations.
So at least a final fix shall:
- use erase suspend for jedec chips for "read only" suspends were 
  cfip == NULL
- use erase suspend for all cfi probed chips for "read only" suspends
  if supported (as indicated by cfip->EraseSuspend)

And for the write case, I can not tell why the erase suspend is viewed to 
be broken here. If we change this,  as in your patch, severe testing is 
needed to make sure it is realy working. Currently I don't have the free 
resources to do this testing. Maybe we'll find some volunteer ?!.......

I'll try to find a fix which will not break current implementations and 
allows updates to implement erase suspend for writes easily. Appriciate 
your comments. 

BTW: who's the maintainer and what are her/his  thoughts. 

Ciao, 

Peter 


|       Peter Wippich                   Voice: +49 30 46776411          |
|       G&W Instruments GmbH            fax:   +49 30 46776419          |
|       Gustav-Meyer-Allee 25, Geb. 12  Email: pewi at gw-instruments.de   |
|       D-13355 Berlin  / Germany                                       |