No subject
Sat Apr 18 12:21:40 EDT 2009
@@ -188,7 +188,6 @@ static int atmel_nand_calculate(struct mtd_info *mtd,
{
struct nand_chip *nand_chip = mtd->priv;
struct atmel_nand_host *host = nand_chip->priv;
- uint32_t *eccpos = nand_chip->ecc.layout->eccpos;
unsigned int ecc_value;
/* get the first 2 ECC bytes */
Which is the same subroutine as your change, but a strange difference in line
numbers. Which makes me think you have changes in this file as well.
>
> Here is the log that I have running with this patch:
> "
> NAND device: Manufacturer ID: 0xec, Chip ID: 0xda (Samsung NAND 256MiB 3,3V 8-bit)
> AT91 NAND: 8-bit, Software ECC
> nand_scan_tail ecc.total = 24, ecc.steps = 8, ecc.bytes = 3, ecc.size = 256, writesize = 2048
> nand_scan_tail oobfree[0].offset=2, .length=38
> Scanning device for bad blocks
> Bad eraseblock 881 at 0x06e20000
> Creating 3 MTD partitions on "atmel_nand":
> 0x00000000-0x00400000 : "Bootstrap"
> 0x00400000-0x04000000 : "Partition 1"
> 0x04000000-0x10000000 : "Partition 2"
> "
>
> All seems ok.
>
> So, with the above line replaced, I would like to add to both patches:
>
> [nicolas.ferre at atmel.com: tested on large page nand sw ECC]
> Tested-by: Nicolas Ferre <nicolas.ferre at atmel.com>
>
> Regards,
Thanks for testing. I appreciate it.
Troy
More information about the linux-mtd
mailing list