[PATCH] UBIFS: correct key comparison
Artem Bityutskiy
dedekind at infradead.org
Tue Sep 30 05:19:06 EDT 2008
From: Adrian Hunter <ext-adrian.hunter at nokia.com>
The comparison was working, but more by accident than design.
Signed-off-by: Adrian Hunter <ext-adrian.hunter at nokia.com>
---
fs/ubifs/tnc_misc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/tnc_misc.c b/fs/ubifs/tnc_misc.c
index a25c1cc..b48db99 100644
--- a/fs/ubifs/tnc_misc.c
+++ b/fs/ubifs/tnc_misc.c
@@ -480,8 +480,8 @@ int ubifs_tnc_read_node(struct ubifs_info *c, struct ubifs_zbranch *zbr,
}
/* Make sure the key of the read node is correct */
- key_read(c, key, &key1);
- if (memcmp(node + UBIFS_KEY_OFFSET, &key1, c->key_len)) {
+ key_read(c, node + UBIFS_KEY_OFFSET, &key1);
+ if (!keys_eq(c, key, &key1)) {
ubifs_err("bad key in node at LEB %d:%d",
zbr->lnum, zbr->offs);
dbg_tnc("looked for key %s found node's key %s",
--
1.5.4.1
More information about the linux-mtd
mailing list