[PATCH] [MTD-UTILS] Add support for 4KB page flash devices

Artem Bityutskiy dedekind at infradead.org
Fri Sep 26 00:48:53 EDT 2008


Hi,

On Fri, 2008-09-26 at 09:28 +0900, Kyungmin Park wrote:
> > We can now use these utilities on 4KB devices.
> >
> > Signed-off-by: Rohit Hagargundgi <h.rohit at samsung.com>
> > ---
> 
> Acked-by: Kyungmin Park <kyungmin.park at samsung.com>

Err, isn't this ABI change which is going to break backward
compatibility and is NO-NO in Linux?

> >  }
> > --- a/include/mtd/mtd-abi.h     2008-09-23 15:36:26.000000000 +0530
> > +++ b/include/mtd/mtd-abi.h     2008-09-23 15:48:48.000000000 +0530
> > @@ -104,7 +104,7 @@ struct nand_oobinfo {
> >        uint32_t useecc;
> >        uint32_t eccbytes;
> >        uint32_t oobfree[8][2];
> > -       uint32_t eccpos[32];
> > +       uint32_t eccpos[128];
> >  };

Err, isn't this ABI change which is going to break backward
compatibility and is NO-NO in Linux?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list