[PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register()

Sergei Shtylyov sshtylyov at ru.mvista.com
Wed Sep 17 15:43:04 EDT 2008


Andrew Morton wrote:

>>The PHYSMAP_COMPAT code had been ignoring the return value of
>>platform_device_register() in the physmap_init() function.

>>Signed-off-by: Zev Weiss <zevweiss at gmail.com>
>>diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
>>index 42d844f..6fba0d4 100644
>>--- a/drivers/mtd/maps/physmap.c
>>+++ b/drivers/mtd/maps/physmap.c
>>@@ -312,7 +312,7 @@ static int __init physmap_init(void)
>>  	err = platform_driver_register(&physmap_flash_driver);
>>  	if (err == 0)
>>-		platform_device_register(&physmap_flash);
>>+		err = platform_device_register(&physmap_flash);
>>  #endif
>>  	return err;

> Your email client is performing space-stuffing, thus making the patches
> unapplyable.

    Er... are you sure? The patch looks alright tab wise, even after quoting...

> Presumably we should run platform_driver_unregister() if the
> platform_device_register() failed.

    Why is that? There could be "normal" platform devices out there...

WBR, Sergei

More information about the linux-mtd mailing list