[PATCH 1/6] [MTD-UTILS] nandwrite: Qualifier Clean-up

[Enrico Scholz]

Grant Erickson <gerickson at nuovations.com> writes:

> +static const char	*mtd_device, *img;

would it be possible to split this into two declarations?  I
really don't know if 'img' points to a constant or non-constant
char...


> -int main(int argc, char **argv)
> +int main(int argc, char * const argv[])

Is this really correct?  C standard mentions only

               int main(void) { /* ... */ }
               int main(int argc, char *argv[]) { /* ... */ }

as program entry points.  I suggest to cast 'argv' to a corresponding
data type when it is used.


Enrico