[PATCH mtd-utils] fix CFLAGS handling wrt cross compilation

Mike Frysinger vapier.adi at gmail.com
Wed Nov 19 20:52:11 EST 2008


On Wed, Nov 19, 2008 at 13:31, Nicolas Pitre wrote:
> Let's have the "new ubi-utils" makefile handle CFLAGS like the other
> makefiles.  This is important when cross compiling and CFLAGS is
> externally provided. Without this, local include files are not found due
> to the various -I arguments which are then lost.
>
> Signed-off-by: Nicolas Pitre <nico at marvell.com>

i dont think sticking CFLAGS into CPPFLAGS is right.  they're separate
on purpose.  you also break custom CPPFLAG injection here ... CPPFLAGS
should be treated just like CFLAGS: appended, not strictly set.
-mike



More information about the linux-mtd mailing list