[PATCH] physmap: Fix leak of memory returned by parse_mtd_partitions
Atsushi Nemoto
anemo at mba.ocn.ne.jp
Wed Nov 12 10:55:34 EST 2008
On Wed, 12 Nov 2008 23:57:33 +0900 (JST), Atsushi Nemoto <anemo at mba.ocn.ne.jp> wrote:
> The mtd partition parser returns an allocated pointer array of
> mtd_partition. The caller must free it. The array is used only for
> add_mtd_partitions(), so free it just after the call.
>
> Signed-off-by: Atsushi Nemoto <anemo at mba.ocn.ne.jp>
> ---
> drivers/mtd/maps/physmap.c | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
And many other callers of parse_mtd_partitions() also do not free the
returned memory. With a quick look, 21 of 36 have same defect.
drivers/mtd/devices/m25p80.c
drivers/mtd/devices/mtd_dataflash.c
drivers/mtd/maps/bfin-async-flash.c
drivers/mtd/maps/edb7312.c
drivers/mtd/maps/impa7.c
drivers/mtd/maps/intel_vr_nor.c
drivers/mtd/maps/solutionengine.c
drivers/mtd/nand/atmel_nand.c
drivers/mtd/nand/cafe_nand.c
drivers/mtd/nand/cmx270_nand.c
drivers/mtd/nand/cs553x_nand.c
drivers/mtd/nand/edb7312.c
drivers/mtd/nand/fsl_elbc_nand.c
drivers/mtd/nand/fsl_upm.c
drivers/mtd/nand/mxc_nand.c
drivers/mtd/nand/orion_nand.c
drivers/mtd/nand/ppchameleonevb.c
drivers/mtd/nand/sharpsl.c
drivers/mtd/nand/tmio_nand.c
drivers/mtd/nand/ts7250.c
drivers/mtd/onenand/generic.c
Volunteers? ;)
---
Atsushi Nemoto
More information about the linux-mtd
mailing list