[PATCH 1/2] mtd: Fix cfi_send_gen_cmd the handling of x16 devices in x8 mode

Eric W. Biederman ebiederm at xmission.com
Sat Nov 1 07:26:50 EDT 2008

David Woodhouse <dwmw2 at infradead.org> writes:

> On Sat, 2008-11-01 at 10:43 +0000, David Woodhouse wrote:
>> I think this one is still broken by your patch -- it's the exception to
>> your observation that we only ever use addresses ending in 00, 55 or aa.
> No, I misunderstood how that works -- your patch is fine. Although I
> think I'll split patch 1/2 into cleanup vs. the actual fix, too.

Sounds good.   The (cmd_ofs & 0xff) == 0xaa might be less prone to false
positives.  Or perhaps it just doesn't make sense for the id reads in jedec_probe.
Sounds like you have a handle on it though.


More information about the linux-mtd mailing list