[PATCH] respect CFLAGS/CPPFLAGS from build environment

[Josh Boyer]

On Wed, 11 Jun 2008 17:49:08 -0400
Mike Frysinger <vapier at gentoo.org> wrote:
 
> diff --git a/ubi-utils/Makefile b/ubi-utils/Makefile
> index 0394eee..062cc32 100644
> --- a/ubi-utils/Makefile
> +++ b/ubi-utils/Makefile
> @@ -2,7 +2,6 @@
>  # Makefile for ubi-utils
>  #
>  
> -OPTFLAGS := -O2 -g -Wall
>  KERNELHDR := ../include
>  DESTDIR := /usr/local
>  SBINDIR=/usr/sbin
> @@ -10,8 +9,10 @@ MANDIR=/usr/share/man
>  INCLUDEDIR=/usr/include
>  
>  CC := $(CROSS)gcc
> -CFLAGS := -I./inc -I./src -I$(KERNELHDR) $(OPTFLAGS) -Werror \
> -	-Wwrite-strings -W -std=gnu99 -DPACKAGE_VERSION=\"1.0\"
> +CFLAGS ?= -O2 -g -Werror
> +CFLAGS += -Wall -Wwrite-strings -W
> +CPPFLAGS += -I./inc -I./src -I$(KERNELHDR) \
> +	-std=gnu99 -DPACKAGE_VERSION=\"1.0\"
>  
>  PERLPROGS = mkpfi ubicrc32.pl
>  
> @@ -26,7 +27,7 @@ vpath   %.c ./src
>  	$(CC) $(LDFLAGS) -g -o $@ $^
>  
>  %.o: %.c
> -	$(CC) $(CFLAGS) -g -c -o $@ $< -g -Wp,-MD,.$(shell basename $<).dep
> +	$(CC) $(CPPFLAGS) $(CFLAGS) -g -c -o $@ $< -g -Wp,-MD,.$(shell basename $<).dep

Should either remove the unconditional -g here, or not specify it in
the default CFLAGS above, correct?

josh