[RFC/PATCH 2/3] NAND multiple plane feature

[Thomas Gleixner]

On Fri, 6 Jun 2008, Alexey Korolev wrote:
> > > 2. existence of such redefinition is redundend. There is definetely
> > > no need to redefine it.
> > 
> > -ENOPARSE
> >
> Ok. Can you show me a reason why write page
> should be in nand_chip structure? Please consider the fact that nobody redefines
> write_page (cafe_nand_write_page and nand_write_page are identical). 

That's not the point. If these functions are the same then of course
there is no need to have it duplicated, but just silently deleting
stuff in a (according to the changelog) unnrelated patch w/o fixing up
what breaks is not how it works.

You want others to review your changes, then please provide them in a
form which do not cause the reviewer to figure out that the function
in cafe.c is identical.

It would have been entirely clear when the patch series would have
contained:

[1/n] remove duplicated write_page function from cafe.c
[2/n] remove now unused write_page function pointer from struct nand_chip

I have only restricted time to do such reviews and I definitely have
no interest to investigate why the heck a change which is completely
unrelated might be correct or useful.

Thanks,

	tglx