[RFC/PATCH 2/3] NAND multiple plane feature
Thomas Gleixner
tglx at linutronix.de
Thu Jun 5 15:13:12 EDT 2008
On Thu, 5 Jun 2008, Alexey Korolev wrote:
> > > - if (!chip->write_page)
> > > - chip->write_page = nand_write_page;
> > > -
> >
> > Why is this removed?
> >
> Oh. May be it would be better to make stand alone patch in order to
> clean up NAND subsystem. Using chip->write_page is redundend here. It
> is set once it is set for write procedure only. There is no chip read
> page call like that. IMHO it is better to use static call here. Please
> let me know if you are agree with this.
No, it's definitely not better to use a static call here. Cared to look
at the existing drivers, whether one provides it's own function ?
drivers/mtd/nand/cafe_nand.c: cafe->nand.write_page = cafe_nand_write_page;
Thanks,
tglx
More information about the linux-mtd
mailing list