[PATCH 2.6.26-git] MTD_DEBUG always does compile-time typechecks

David Brownell david-b at pacbell.net
Wed Jul 30 01:28:12 EDT 2008


From: David Brownell <dbrownell at users.sourceforge.net>

The current style for debug messages is to ensure they're always
parsed by the compiler and then subjected to dead code removal.
That way builds won't break only when debug options get enabled,
which is common when they are stripped out early by CPP.

This patch makes CONFIG_MTD_DEBUG adopt that convention.

Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
---
 include/linux/mtd/mtd.h |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- a/include/linux/mtd/mtd.h	2008-07-29 22:06:43.000000000 -0700
+++ b/include/linux/mtd/mtd.h	2008-07-29 22:19:21.000000000 -0700
@@ -272,7 +272,11 @@ static inline void mtd_erase_callback(st
 			printk(KERN_INFO args);		\
 	} while(0)
 #else /* CONFIG_MTD_DEBUG */
-#define DEBUG(n, args...) do { } while(0)
+#define DEBUG(n, args...)				\
+	do {						\
+		if (0)					\
+			printk(KERN_INFO args);		\
+	} while(0)
 
 #endif /* CONFIG_MTD_DEBUG */
 



More information about the linux-mtd mailing list