[PATCH] at91_nand: Make part_probes[] static

Jörn Engel joern at logfs.org
Tue Jan 29 18:17:43 EST 2008


On Tue, 29 January 2008 22:28:37 +0900, Atsushi Nemoto wrote:
> 
> This patch fixes this sparse warning:
> 
> linux/drivers/mtd/nand/at91_nand.c:86:12: warning: symbol 'part_probes' was not declared. Should it be static?

You cannot fix a warning.  You can only fix code.  Warnings can be and
often are wrong.  This particular is right, so in spite of the
description
Acked-by: Joern Engel <joern at logfs.org>

> Signed-off-by: Atsushi Nemoto <anemo at mba.ocn.ne.jp>
> ---
> diff --git a/drivers/mtd/nand/at91_nand.c b/drivers/mtd/nand/at91_nand.c
> index b2a5672..9adbf2a 100644
> --- a/drivers/mtd/nand/at91_nand.c
> +++ b/drivers/mtd/nand/at91_nand.c
> @@ -83,7 +83,7 @@ static void at91_nand_disable(struct at91_nand_host *host)
>  }
>  
>  #ifdef CONFIG_MTD_PARTITIONS
> -const char *part_probes[] = { "cmdlinepart", NULL };
> +static const char *part_probes[] = { "cmdlinepart", NULL };
>  #endif
>  
>  /*
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Jörn

-- 
Joern's library part 11:
http://www.unicom.com/pw/reply-to-harmful.html



More information about the linux-mtd mailing list