[PATCH][JFFS2] Fix garbage collector block search

Alexander Belyakov abelyako at googlemail.com
Fri Jan 18 11:28:08 EST 2008


On 1/15/08, Jörn Engel <joern at logfs.org> wrote:
>
> Right now the important thing is to dig deeper and understand the nature
> of this bug.  You can reproduce it, that is good.  We also know that it
> makes a difference whether the block is on one list or the other.  But
> we don't know yet, what difference exactly it makes.

Question. What is success criteria for jffs2_garbage_collect_pass() execution?

Why asking? In the case described above jffs2_find_gc_block() fails to
find erase block for garbage collection but falling into
jffs2_flush_wbuf_pad(c) which produces amount of erasing blocks. So
jffs2_garbage_collect_pass() sees no single block for garbage
collection, but filesystem still recieves fresh erasing blocks upon
execution.

Is it success or failure? Theoretically.

Thanks,
Alexander


More information about the linux-mtd mailing list