[PATCH] basic pxa3 nand controller support

[eric miao]

On Jan 11, 2008 7:44 PM, Sergey Podstavin <spodstavin at ru.mvista.com> wrote:
> This is a fixed version for pxa3 nand controller,
> working on pxa300 Zylonite

great, thanks for trying this. It looks like a bunch of things are added back
from previous marvell released packages :-)

1. io mapping is not recommended for peripheral drivers, we instead use
   ioremap() in the nand driver, so it's not a must to map those registers
   when pxa_map_io()

2. as I said, those DRCMRxx macros can be well replaced by DRCMR(xx),
   the original DRCMR(xx) macro has an issue, which is corrected by
   recent patch sent to RMK, and is supposed to be merged in recent
   .24-rc7

3. partition tables should be moved outside of the driver into platform
   code

Apart from the above, could you let me know which modifications you
made this work? You know it's a big patch, and is difficult for line to line
comparison with my original one..., thanks!

>
> Best wishes,
> Sergey Podstavin.
>
>
> >eric miao <eric.y.miao <at> gmail.com> writes:
> >
> >> Early feedback is welcome, thanks!
> >
> >Hi Eric
> >
> >Overall the patch looks good, just a few comments.
> >
> >The patch does not apply cleanly unless I remove the spurious newline before
> >line 1284 resulting in the following error:
> >patch: **** malformed patch at line 1284: pm_message_t state)
> >
> >The DRCMR97 register is not defined anywhere, at lest not in 2.6.24-rc6:
> >drivers/mtd/nand/pxa3xx_nand.c:542: error: 'DRCMR97' undeclared (first use in
> >this function)
> >
> >The registers and bit definitions should be moved to pxa-regs.h, not?
> >
> >I had my troubles getting it to work on a custom PXA320 board. I kinda figured
> >out what platform data it needs, but still can't seem to get it to work properly:
> >pxa3xx-nand pxa3xx-nand: failed to detect flash
> >
> >What kernel does your patch apply to? What CPUs/boards did you try it on? Can
> >you provide an example platform integration required to make it work?
> >
> >Cheers
> >
> >Marcel
>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
>



-- 
Cheers
- eric