[PATCH 1/2] Makefile export shared libraries

Corentin Chary chary_c at epitech.net
Thu Dec 18 15:00:51 EST 2008


On Thu, Dec 18, 2008 at 8:12 PM, Josh Boyer <jwboyer at gmail.com> wrote:
>
> I don't see where you actually create a shared library here.  There
> is no soname set, for example.  I'm not opposed to creating shared
> libraries, but it should be done properly so that if the API/ABI
> changes then we can bump the soname, etc.

The rules  which create the .so are:

shared: $(addsuffix .so, $(LIBS))
%.pic.o: %.c
      $(CC) $(CFLAGS) -fPIC $(CPPFLAGS) $< -c -o $@
%.so: %.pic.o
      $(CC) $(LDFLAGS) -shared -o $@ $^

We forgot to add -Wl,-soname,foo .
Is there anything else ?
If it's ok we will re-send the patch tomorow.



-- 
Corentin Chary
http://xf.iksaif.net



More information about the linux-mtd mailing list