ubifs: another scheduling while atomic back trace

[Cal Page]

I tracked it down to fs/ubifs/journal.c in make_reservation()?

the code is:
    again:
       down_read()
       err = reserve_space()
       if ( !err) return 0
       up_read()

shouldn't we to the up as part of the if? ie

    if ( !err ) { up_read(); return 0; };

Also, I notice fs/fs-writeback.c in writeback_inodes does a 
down_read_trylock. Won't this interfear with the down_read above?

Cal Page