ubi-utils updates for gcc-4.3.x
dedekind at infradead.org
Mon Dec 8 08:09:42 EST 2008
On Mon, 2008-12-08 at 13:00 +0200, Artem Bityutskiy wrote:
> >From man scanf:
> RETURN VALUE
> These functions return the number of input items successfully
> matched and assigned, which can be fewer than provided for, or even zero
> in the event of an early matching failure.
> The value EOF is returned if the end of input is reached before either
> the first successful conversion or a matching failure occurs. EOF is
> also returned if a read error occurs, in which case the error indicator
> for the stream (see ferror(3)) is set, and errno is set indicate the
> On this basis, I would say you should test for EOF, not for 0.
> > + if (!scanf("%3s", buf))
> > + return 0;
If you are fine with this, I may amend your patch and push it, because
otherwise it looks OK for me.
Artem Bityutskiy (Битюцкий Артём)
More information about the linux-mtd