[PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put
Olof Johansson
olof at lixom.net
Mon Dec 1 13:08:12 EST 2008
On Mon, Dec 01, 2008 at 06:39:01PM +0100, Julia Lawall wrote:
> On Mon, 1 Dec 2008, Olof Johansson wrote:
>
> > On Thu, Nov 27, 2008 at 01:19:49PM +0100, Julia Lawall wrote:
> > > From: Julia Lawall <julia at diku.dk>
> > >
> > > pci_get_device increments a reference count that should be decremented
> > > using pci_dev_put. I have thus added an extra label in the error handling
> > > code to do this. I don't know, however, whether there should be a
> > > pci_dev_put before the return 0 as well.
> > >
> > [...]
> >
> > > Signed-off-by: Julia Lawall <julia at diku.dk>
> >
> > Acked-by: Olof Johansson <olof at lixom.net>
>
> Do you know the answer about the return 0?
Teaches me to read the patch description twice.
Either there or in pasemi_nand_remove(), doesn't matter much to me. Doing
it before the return 0 is the smaller change.
-Olof
More information about the linux-mtd
mailing list