[PATCH] add missing cmdset field in PXA3xx NAND code

Daniel Mack daniel at caiaq.de
Mon Dec 1 06:57:57 EST 2008


This adds a missing .cmdset parameter for STM 2G NAND chip
definition. Even though support for built-in NAND chips is
marked deprecated, the driver crashes in __readid() due to a NULL
pointer dereference if it's not there.

Signed-off-by: Daniel Mack <daniel at caiaq.de>

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index c0fa9c9..ff4d28e 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -269,6 +269,7 @@ static struct pxa3xx_nand_timing stm2GbX16_timing = {
 
 static struct pxa3xx_nand_flash stm2GbX16 = {
        .timing = &stm2GbX16_timing,
+       .cmdset = &largepage_cmdset,
        .page_per_block = 64,
        .page_size = 2048,
        .flash_width = 16,




More information about the linux-mtd mailing list