[PATCH] [MTD] [NAND] nand_ecc.c: adding support for 512 byte ecc

[David Woodhouse]

On Fri, 2008-08-22 at 10:43 +0200, Frans Meulenbroeks wrote:
> @David (dwmw2)
> Please let me know what the preferred way to integrate this. I can
> either provide a patch on top of Vimal' patch if needed, or I can add
> my changes to it and submit a patch containing the work of both of us,
> or I can send my changes as review comment to Vimal and let him make
> the patch. What is the preferred way? (and I highly prefer a solution
> where Vimal gets credit for his changes)

When you forward the patch on to me, put 'From: Vimal Singh <...>'  as
the first line of the _body_ of the email so that it is still attributed
to him. It's reasonable to preserve his signed-off-by, if you're only
making relatively minor changes, and document what _you_ changed in
square brackets. For an example, see
http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg00461.html

Alternatively, if his patch isn't actually introducing a regression, it
doesn't hurt to do it as two separate patches -- whichever you prefer.

When resending an updated patch, make sure the proper commit comment
remains intact -- if you want to add some commentary like 'fixed up
according to review and made some other fixes', which doesn't live in
the commit comment but follows on from the email thread, then add it
after a line with three dashes -- again, you can see that in the example
above.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation