[PATCH] [MTD] [NAND] nand_ecc.c: adding support for 512 byte ecc

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Thu Aug 21 14:39:25 EDT 2008


Hi Vimal,

Thanks for your patch.
I tried to apply your patch, but only hunk 1 succeeded with fuzz 2.
Guess this is because shortly after submitting my patch another patch
has been applied to it.
Could you verify against the latest version in git and resubmit the patch.

Also there are a few small optimisation possibilities.
E.g. the code:
+       if (j == 2)
+               rp16 = 0;
Here the if statement does not really add. for 256 byte ecc
initialising rp16 does not harm so the if statement creates additional
overhead.

There are a fw more of these (like the /256 reported by Artem.
I'll happily fix these once I have a patch that I can apply.

Best regards, Frans



More information about the linux-mtd mailing list