[PATCH] Remove duplicated unlikely() in IS_ERR()

Artem Bityutskiy dedekind at infradead.org
Tue Aug 19 01:55:20 EDT 2008


On Fri, 2008-08-15 at 16:16 +0900, Hirofumi Nakagawa wrote:
> Hi
> Some drivers have duplicated unlikely() macros.
> IS_ERR() already has unlikely() in itself.
> This patch cleans up such pointless codes although there is no real
> effect on the kernel's behaviour.
> 
> Thanks,
> Hirofumi Nakagawa
> 
> Signed-off-by: Hirofumi Nakagawa <hnakagawa at miraclelinux.com>
> ---

Hmm, after thinking a bit I am not sure this is the right way to go.
Indeed, we try to avoid likly()/unlikely(), unless this is really
hot-path. Some kernel developers even think these hints should never
be used. So I'd say, the right thing would bo to remove unlikely()
from IS_ERR() macro instead.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list