[RESUBMIT] [PATCH] [MTD] NAND nand_ecc.c: rewrite for improved performance

[Frans Meulenbroeks]

2008/8/17, Troy Kisky <troy.kisky at boundarydevices.com>:
> frans wrote:
>  >
>  > On Fri, 15 Aug 2008, Troy Kisky wrote:
>  >> You might also test it on a big endian system to be safe.
>  >>
>  >> Troy
>  >>
>  > Good remark!
>  > I should have mentioned this more explicitly. As mentioned before I did test
>  > on Linksys NSLU2. This is an ARM and standard Linksys software (as well as
>  > the std unslung one from nslu2-linux.org) is big endian (and yes, that
>  > is the part I did not mention).
>  >
>
>
> So, you have tried reading a file system that was created before your patch
>  was applied on a big endian system? Sorry to be a pest, but I didn't see any
>  endian-ness test in your patch. But I will admit that my eyes aren't very good.
>  I'm especially bad at spotting the jelly in the fridge. :^)
>
Yes, the NSLU2 had a filesystem that was created before the patch was applied.
But actually I think the filesystem is irrelevant.
I verified the proper operation by comparing the values generated by
the original code with the values generated by my code over a set of
input blocks.
Guess there is no endianness dependency and that if the data is big
endian the ecc is too.

Frans.