[CFI] Cleanup of missprint in probe procedure.

Alexey Korolev akorolev at infradead.org
Tue Aug 5 09:15:01 EDT 2008


Hi,

Here is a small missprint in CFI probe detect aliasing procedure. 
Please look at the lines 161&162 of cfi_probe.c

160:	/* FIXME: Use other modes to do a proper check */
161:	cfi_send_gen_cmd(0xF0, 0, base, map, cfi, cfi->device_type, NULL);
162:	cfi_send_gen_cmd(0xFF, 0, start, map, cfi, cfi->device_type, NULL);
163:

If I properly understand we should send these commands at the same addresses. (base address)

The following diff fixes it. 

diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index c418e92..1b61eb4 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -159,7 +159,7 @@ static int __xipram cfi_probe_chip(struct map_info *map, __u32 base,
 			 * too and if it's the same, assume it's an alias. */
 			/* FIXME: Use other modes to do a proper check */
 			cfi_send_gen_cmd(0xF0, 0, base, map, cfi, cfi->device_type, NULL);
-			cfi_send_gen_cmd(0xFF, 0, start, map, cfi, cfi->device_type, NULL);
+			cfi_send_gen_cmd(0xFF, 0, base, map, cfi, cfi->device_type, NULL);
 
 			if (qry_present(map, base, cfi)) {
 				xip_allowed(base, map);




More information about the linux-mtd mailing list