[PATCH] physmap: do not probe absent modules
Atsushi Nemoto
anemo at mba.ocn.ne.jp
Mon Apr 28 11:01:00 EDT 2008
On Mon, 28 Apr 2008 09:26:02 +0100, David Woodhouse <dwmw2 at infradead.org> wrote:
> > For example, if MTD_CFI was not enabled, probing it does nothing other
> > than just produces an error message.
>
> Eww. We should _never_ have stuff in the static kernel depending on
> CONFIG_xxx_MODULE. What if you build the module later?
OK, I see.
> I wouldn't be entirely averse to making some of these config options
> boolean, though.
Well, maybe, but I'm not sure nobody want to make the redboot parser
loadable.
My intention was just removing a garbage in boot message. How about
this alternative? Is this acceptable?
-----------------------------------------------------------------
Subject: mtdpart: Do not report loud about absent parser module
Signed-off-by: Atsushi Nemoto <anemo at mba.ocn.ne.jp>
---
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index c66902d..f199ffc 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -560,7 +560,7 @@ int parse_mtd_partitions(struct mtd_info *master, const char **types,
parser = get_partition_parser(*types);
#endif
if (!parser) {
- printk(KERN_NOTICE "%s partition parsing not available\n",
+ printk(KERN_DEBUG "%s partition parsing not available\n",
*types);
continue;
}
More information about the linux-mtd
mailing list