[PATCH] Fix of broken state in CFI driver caused by FL_SHUTDOWN

Nicolas Pitre nico at cam.org
Wed Apr 9 19:02:26 EDT 2008


On Thu, 10 Apr 2008, Joakim Tjernlund wrote:

> > -----Original Message-----
> > From: linux-mtd-bounces at lists.infradead.org [mailto:linux-mtd-bounces at lists.infradead.org] On Behalf
> > Of Alexey Korolev
> > Sent: den 4 april 2008 14:22
> > To: Jörn Engel
> > Cc: nico at cam.org; haokexin at gmail.com; dwmw2 at infradead.org; akpm at linux-foundation.org; linux-
> > mtd at lists.infradead.org
> > Subject: Re: [PATCH] Fix of broken state in CFI driver caused by FL_SHUTDOWN
> > 
> > Hi
> > 
> > 
> >  CFI driver in 2.6.24 kernel is broken. Not so intensive read/write operations cause incomplete writes
> > which lead to kernel panics in JFFS2.
> >  We investigated the issue - it is caused by bug in FL_SHUTDOWN parsing code. Sometimes chip returns -
> > EIO as if it is in FL_SHUTDOWN state when it should wait in FL_PONT (error in order of conditions).
> > 
> > The following patch fixes the bug in state parsing code of CFI.
> > Also I've added comments to notify developers if they want to add new case in future.
> > Please include it.
> > 
> > Signed-off-by: Alexey Korolev <akorolev at infradead.org>
> > Reviewed-By: Joern Engel <joern at logfs.org>
> 
> Acked-By: Joakim Tjernlund <Joakim.Tjenrlund at transmode.se>
> 
> Guys, I think you should sent this directly to Linus as David seems
> unavailable ATM. It should really go into 2.6.25

It is already in mainline.  See commit fb6d080c.


Nicolas


More information about the linux-mtd mailing list