[PATCH] Fix of broken state in CFI driver caused by FL_SHUTDOWN

Alexey Korolev akorolev at infradead.org
Fri Apr 4 08:10:27 EDT 2008


Hi Jörn

> 
> Ouch!  I've been bitten by these before.  After I've carefully written
> code that takes advantage of missing break; statements, a colleague of
> mine reordered the code and missed those subtleties.
> 
> Could you add a comment like this where appropriate:
> 		/* fall through */
No problem. See patch update in next message. 
> 
> It might even have prevented this bug if Kevin had seen such a comment
> before writing his patch.
> 
> Reviewed-By: Joern Engel <joern at logfs.org>
> 
> >  
> > -	case FL_SHUTDOWN:
> > -		/* The machine is rebooting now,so no one can get chip anymore */
> > -		return -EIO;
> >  	default:
> >  	sleep:
> >  		set_current_state(TASK_UNINTERRUPTIBLE);
> 
> 


More information about the linux-mtd mailing list