[PATCH try 2] MTD: OneNAND: fix numerous races

Kyungmin Park kmpark at infradead.org
Wed Sep 26 19:50:48 EDT 2007


Hi,

Sorry for late replying.
Look good to me except one typo.

Acked-by: Kyungmin Park <kyungmin.park at samsung.com>

> @@ -2052,7 +2063,12 @@ static int do_otp_write(struct mtd_info *mtd, loff_t from, size_t len,
>  	this->command(mtd, ONENAND_CMD_OTP_ACCESS, 0, 0);
>  	this->wait(mtd, FL_OTPING);
> 
> -	ret = mtd->write(mtd, from, len, retlen, pbuf);
> +	ops.len = len;
> +	ops.ooblen = 0;
> +	ops.databuf = pbuf;

It should be ops.datbuf.

> +	ops.oobbuf = NULL;
> +	ret = onenand_write_ops_nolock(mtd, to, &ops);
> +	*retlen = ops.retlen;




More information about the linux-mtd mailing list