[PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16()

Jörn Engel joern at logfs.org
Sun Oct 21 04:48:39 EDT 2007

On Sun, 21 October 2007 10:06:53 +0200, Thomas Gleixner wrote:
> No. It should never happen, but escalating an error which the kernel
> can survive under a lot of circumstances to a fatal death error is
> wrong.

I am unimpressed.  This error is not some rare hardware error, it is a
programming error, a bug in the kernel.  And until now it was handled by
hiding it as a _corrected_ crc error.  If you want to handle it in a
non-fatal way, you can do it.  But that requires more than just
reverting this patch - you should also properly document why an
"impossible" error is indeed possible and how calling code should deal
with it.  And of course make sure current code follows documentation and
does the right thing.

Is all that worth it?  I have serious doubts.


Never argue with idiots - first they drag you down to their level,
then they beat you with experience.
-- unknown

More information about the linux-mtd mailing list