Recursion in CFI driver. Is it really necessary to have.
akorolev at infradead.org
Wed Oct 17 13:00:57 EDT 2007
> One issue: you now force the resettime behavior for every cases. Should
> we care?
Yes you are right. This message is for debugging purposes. I would not care becuase it is hard to make code beauty and keep this debuging print.
> Also some style issues:
>> @@ -709,6 +709,23 @@
>> + ret = chip_ready(map, chip, adr, mode);
>> + if (ret == -EAGAIN)
>> + goto retry;
>> + return ret;
> One blank line too many above.
>> +static int chip_ready (struct map_info *map, struct flchip *chip, unsigned
>> long adr, int mode)
> You'll have to add a prototype for that function which is called before
> its definition.
Oh thank you! I will correct it and create a new thread for the patch.
More information about the linux-mtd