[PATCH] MTD: OneNAND: Return only negative error codes

Artem Bityutskiy dedekind at infradead.org
Sun Oct 14 04:14:08 EDT 2007


On Fri, 2007-10-12 at 18:30 +0900, Kyungmin Park wrote:
> > The OneNAND driver was confusing JFFS2 by returning positive error
> > codes.
> 
> It's only possible the write case error and it returns the positive 'ctrl' error.
> Other case, "2-bit ecc error' is handled with 'mtd->ecc_stat' correctly.
> 
> Well, no problem to change to the negative value.
> 
> Acked-by: Kyungmin Park <kyungmin.park at samsung.com>

Yeah, it's rare but we caught this in practice, and JFFS2 just calls
BUG() if OneNAND returns positive number while JFFS2 is scanning the
flash medium.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list