bit flip

[catboat at texas.net]

Quoting David Woodhouse <dwmw2 at infradead.org>:

> On Wed, 2007-10-03 at 14:32 -0500, catboat at texas.net wrote:
> > A NAND card flipped a bit and caused a data CRC problem in a data node. 
> > When I cat the file, this region is zeroes. cat exits with rc 0.
> 
> On NAND you should have ECC to prevent this failure mode.

We took two bit flips within the same 256 byte subpage. To my knowledge
ECC won't correct it, but should have returned an error.  I think 
UBI handled the error and copied what it could to a new erase block.
After that, the ECC words were correct again, but not the jffs2
CRC check. 

Regarding a change to the code, jffs2 needs to track data nodes 
that have CRC problems instead of marking them obsolete. Maybe a new
node type could represent this and save recalculating CRCs everywhere. 
Until these nodes are rewritten with newer data, I would expect readers 
of the nodes to get EIO.

Monte