Review status (Re: [PATCH] LogFS take three)

[Evgeniy Polyakov]

On Wed, May 23, 2007 at 05:14:04PM +0200, Jörn Engel (joern at lazybastard.org) wrote:
> > > I'm just a German.  Forgive me if I drink lesser beverages.
> > 
> > You should definitely change that.
> 
> Change being German?  Not a bad idea, actually.

You cook up really tasty shnaps, in small quantities it is good for
health in infinite volumes.

> > Btw, what about this piece:
> > 
> > int logfs_erase_segment(struct super_block *sb, u32 index)
> > {
> > 	struct logfs_super *super = LOGFS_SUPER(sb);
> > 
> > 	super->s_gec++;
> > 
> > 	return mtderase(sb, index << super->s_segshift, super->s_segsize);
> > }
> > 
> > index << super->s_segshift might overflow, mtderase expects loff_t
> > there, since index can be arbitrary segment number, is it possible, that
> > overflow really occurs?
> 
> Indeed it is.  You just earned your second beer^Wvodka.

Actually this code looks less encrypted than ext2 for, which definitely
a good sign from reviewer's point of view.

> Jörn

-- 
	Evgeniy Polyakov