AW: [PATCH] [MTD] NAND: Wrong calculation of page number innand_block_bad()
Thomas Gleixner
tglx at linutronix.de
Wed May 2 11:18:14 EDT 2007
On Wed, 2007-05-02 at 14:14 +0200, Knobloch, Thomas wrote:
> On Fri, 2007-04-27 at 19:04, Thomas Gleixner wrote:
> > Can you please make this outside the else path, so we can remove same
> > code in the if (getchip) path.
> >
> > Please also apply the pagemask right there so we don't have it in both
> > cmdfunc() calls.
>
> I added the requested code cleanup to the original patch:
If you now manage to send a non line wrapped patch with the log message
and your Signed-off-by, then I can apply it right from the mail.
Thanks,
tglx
> if (chip->options & NAND_BUSWIDTH_16) {
> chip->cmdfunc(mtd, NAND_CMD_READOOB, chip->badblockpos &
> 0xFE,
> + chip->cmdfunc(mtd, NAND_CMD_READOOB, chip->badblockpos,
> page);
> if (chip->read_byte(mtd) != 0xff)
> res = 1;
> }
More information about the linux-mtd
mailing list