JFFS2 OOPS in 2.6.20

[David Woodhouse]

On Fri, 2007-03-09 at 11:46 +0100, Joakim Tjernlund wrote:
> Tested your patch and now it boots again with this :) 
> JFFS2 error: (137) read_unknown: REF_UNCHECKED but unknown node at 0x3aa28fc
> JFFS2 error: (137) read_unknown: Node is {0000,0000,00000000,00000000}. Please report this error.

Stupid dwmw2. No biscuit.

diff -u b/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
--- b/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -585,7 +585,7 @@
 		}
 		/* Due to poor choice of crc32 seed, an all-zero node will have a correct CRC */
 		if (!je32_to_cpu(node->u.hdr_crc) && !je16_to_cpu(node->u.nodetype) &&
-		    !je16_to_cpu(node->u.magic) && je32_to_cpu(node->u.totlen)) {
+		    !je16_to_cpu(node->u.magic) && !je32_to_cpu(node->u.totlen)) {
 			JFFS2_NOTICE("All zero node header at %#08x.\n", ref_offset(ref));
 			jffs2_mark_node_obsolete(c, ref);
 			goto cont;
diff -u b/fs/jffs2/scan.c b/fs/jffs2/scan.c
--- b/fs/jffs2/scan.c
+++ b/fs/jffs2/scan.c
@@ -736,7 +736,7 @@
 		}
 		/* Due to poor choice of crc32 seed, an all-zero node will have a correct CRC */
 		if (!je32_to_cpu(node->hdr_crc) && !je16_to_cpu(node->nodetype) &&
-		    !je16_to_cpu(node->magic) && je32_to_cpu(node->totlen)) {
+		    !je16_to_cpu(node->magic) && !je32_to_cpu(node->totlen)) {
 			noisy_printk(&noise, "jffs2_scan_eraseblock(): All zero node header at 0x%08x.\n", ofs);
 		       
 			if ((err = jffs2_scan_dirty_space(c, jeb, 4)))

-- 
dwmw2