[PATCH] [MTD] Correct partition failed erase address

David Woodhouse dwmw2 at infradead.org
Thu Mar 8 05:43:13 EST 2007


On Thu, 2007-03-08 at 12:36 +0200, Adrian Hunter wrote:
> ext David Woodhouse wrote:
> > On Thu, 2007-03-08 at 10:27 +0000, David Woodhouse wrote:
> >> Erase isn't always synchronous. It can return success (i.e. erase queued
> >> successfully) and later call the callback with an indication of failure. 
> > 
> > ... and mtd_erase_callback() already subtracts the necessary offset.
> > 
> > I really don't like our API very much, but it doesn't seem to be broken
> > in this particular way.
> 
> Yes it is broken. Both when the callback is not used at all, and when 
> an error occurs immediately and the callback is not called.

Ew, you're right -- and the API is worse than I thought.

Sorry (on both counts) :)

-- 
dwmw2





More information about the linux-mtd mailing list