[PATCH] [JFFS2] Fix unreasonable jffs2_do_reserve_space() failure
Alexander Belyakov
abelyako at googlemail.com
Fri Jun 29 05:31:52 EDT 2007
On 6/29/07, Kyungmin Park <kyungmin.park at samsung.com> wrote:
> Hi,
>
> After this patch, I can't delete the existing files. So we can't operation
> anymore.
It's strange. You should understand that pre patch
jffs2_refile_wbuf_blocks() could also put block to erasable_list. I
mean random ((jiffies + (n++)) & 127) condition. So basically patch
doesn't change that behavior. We just _always_ put one block in
erasable_list if it is empty. Pre patch version does exactly the same
but with some randomness.
>
> How about to reserve the one more block to GC for this case?
>
Don't feel it is necessary.
> The following is my scenario.
>
Just tried to delete/write/mount/unmount with patched JFFS2 and found
no issues you have described.
My point is if you got these errors with patch applied, you _must_ get
them w/o patch as well (but with some randomness).
Thanks,
Alexander
More information about the linux-mtd
mailing list