ubi: Error freeing ubi->vtbl while unloading

Josh Boyer jwboyer at gmail.com
Sun Jun 17 20:59:35 EDT 2007


On 6/17/07, Artem Bityutskiy <dedekind at infradead.org> wrote:
> On Fri, 2007-06-15 at 15:31 +0530, Vinit Agnihotri wrote:
> > I downloaded latest git & backported ubi to make it work in linux
> > kernel 2.6.18.3.
> >
> > Machine details
> >  AMD opteron 64bit SMP, linux kernel version 2.6.18.3
> >
> > However while unloading ubi I discovered slab corruption. Ths problem
> > is as follows.
> >
> > ubi->vtbl is allocated using vmalloc() in vtbl.c empty_create_lvol(),
> > but it is freed in build.c with kfree()
>
> Thanks, fixed the patch, added Signed-off-by and committed.

You added Vinit's sign off, which was missing in the first place.  Not
that I really care, but you shouldn't do that for other people.  Since
you had to fix the patch anyway, you could have done a "Reported-By:"
or something similar and it wouldn't have raised my paranoia flags at
all.

josh



More information about the linux-mtd mailing list