[PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL
dsaxena at plexity.net
Fri Jul 13 02:33:47 EDT 2007
On Jun 20 2007, at 20:52, Josh Boyer was caught saying:
> On 6/20/07, Mark A. Greer <mgreer at mvista.com> wrote:
> > The flash_eraseall MTD utility uses the MEMGETOOBSEL so add a
> > COMPATIBLE_IOCTL() entry for it.
> > Signed-off-by: Mark A. Greer <mgreer at mvista.com>
> > ---
> > I know MEMGETOOBSEL is supposed to be obsolete but flash_eraseall uses
> > it so...
> > Also, MEMSETOOBSEL is used by nandwrite.c but that ioctl doesn't appear
> > to be implemented so I didn't add it. My util source is
> > http://ftp.linux.org.uk/pub/people/dwmw2/mtd/cvs/mtd/util/
> > in case I'm looking at old source.
> You are. But it's still the same in the current code:
> And now that you've found MEMSETOOBSEL being used but not implemented,
> I'll have to go figure out what that's about.
I'm merging Mark's patch into the MontaVista tree and will send out and
updated patch vs upstream but also wondering what the proper route is for
MEMSETOOBSEL? I've been out of the mtd loop for a while but looking at the
git log for mtd-abi.h and mtdchar.c, it looks like the ioctl() was removed
over a year ago (commit ff268fb8791cf18df536113355d7184007c269d9). Do we
re-introduce it or can we update the tools?
Thomas, I'm including you b/c you made the original commit to remove
MEMSETOOBSEL but also made changes to nandwrite.c that use it a month
later. :) Should we put MEMSETOOBSEL back in?
Deepak Saxena - dsaxena at plexity.net - http://www.plexity.net
"Ever bigger machines, entailing ever bigger concentrations of economic
power and exerting ever greater violence against the environment, do not
represent progress: they are a denial of wisdom. Wisdom demands a new
orientation of science and technology towards the organic, the gentle, the
non-violent, the elegant and beautiful." - Small is Beautiful
More information about the linux-mtd