Bogus usage of HZ in cfi_cmdset_0001.c

Guennadi Liakhovetski gl at dsa-ac.de
Thu Jul 5 08:53:46 EDT 2007


Hi

There are several places in cfi_cmdset_0001.c (possibly others?) like

		} else if (usec >= 1000000/HZ) {
		if (sleep_time >= 1000000/HZ) {
			sleep_time = 1000000/HZ;
	udelay = (!extp || !(extp->FeatureSupport & (1 << 5))) ? 1000000/HZ : 0;

which means timeout (e.g., waiting for hardware) are hard-coded in ticks, 
which can have variable duration. What should they really be?

The problem I am seeing is that on a PXA270-based system the unlock 
operation sometimes returns with a timeout, when the CPU is running with 
520MHz, no problem up to 416MHz. Any idea?

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany



More information about the linux-mtd mailing list