[PATCH] [2.6.23] nand_flash_dev - add manufacturer ID

Thomas Gleixner tglx at linutronix.de
Wed Jul 4 01:55:54 EDT 2007


On Tue, 2007-07-03 at 20:03 -0400, David Woodhouse wrote:
> The difference between LP_OPTIONS and the options you've set for the new
> chip is just NAND_NO_PADDING | NAND_COPYBACK, right? Neither of which we
> actually use right now _anyway_.
> 
> I wonder if we should do this differently, and mask certain features in
> or out according to the manufacturer, after identifying the chip.

We do that already:

        /* Check if chip is a not a samsung device. Do not clear the
         * options for chips which are not having an extended id.
         */
        if (*maf_id != NAND_MFR_SAMSUNG && !type->pagesize)
                chip->options &= ~NAND_SAMSUNG_LP_OPTIONS;

So we should do this for that one as well.

	tglx





More information about the linux-mtd mailing list